RUST-2035 Fix invocation of mongosh for requireApiVersion #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What if we instead add to to PATH here? |
|
I can follow up with a PR with a REQUIRE_API_VERSION test in drivers-tools as well. I'll also need to add a test for invoking |
That would work as well, but I'm generally more a fan of keeping state explicit 🙂 It's also more consistent with how mongosh is called from other scripts in this repo. |
|
test-oidc-k8s-local is a known flakey test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2035
Example failing run and passing run against my fork with the fix.
I'm honestly not sure how this worked before;
mongoshis moved into the$MONGODB_BINARIESpath by the install script and isn't in$PATH.