Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine fetch source and prepare resources in EVG config.yml #500

Merged
merged 10 commits into from
Oct 2, 2024

Conversation

Jibola
Copy link
Contributor

@Jibola Jibola commented Sep 20, 2024

No description provided.

@blink1073
Copy link
Member

This is hard to review because of the yaml reformatter. Can we do that as a separate PR so we can add it to git-blame-ignore-revs?

@Jibola
Copy link
Contributor Author

Jibola commented Sep 20, 2024

This is hard to review because of the yaml reformatter. Can we do that as a separate PR so we can add it to git-blame-ignore-revs?

Whoops. Thanks for pointing that out. Didn't mean to place in the autoformatting.

@blink1073
Copy link
Member

Please set the PROJECT_DIRECTORY environment variable.

@blink1073
Copy link
Member

There is a merge conflict

@blink1073
Copy link
Member

It looks like UPLOAD_BUCKET isn't being set properly, maybe add some debug logging?

@Jibola
Copy link
Contributor Author

Jibola commented Oct 2, 2024

need to remove additional calls to prepare resources

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jibola Jibola merged commit 5ef3435 into mongodb-labs:master Oct 2, 2024
58 of 59 checks passed
adriandole pushed a commit to adriandole/drivers-evergreen-tools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants