DRIVERS-2999 Use isolated orchestration file #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
approved these changes
Oct 7, 2024
eramongodb
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Minor feedback; otherwise, LGTM.
FYI mongodb/mongo-c-driver#1742 refactored the C Driver EVG config to use run-orchestration.sh instead of its own custom logic (including use of ABSOLUTE_PATH_REPLACEMENT_TOKEN, which is no longer present) so it should be less prone to breakage from DET script refactors from now on.
Co-authored-by: Ezra Chung <88335979+eramongodb@users.noreply.github.com>
blink1073
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents us from modifying the orchestration files in place that use ABSOLUTE_PATH_REPLACEMENT_TOKEN.
Tested with the C driver: https://spruce.mongodb.com/version/67041e9b7f1bfe000734ae39/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC