Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing return to mock KMS server #543

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Nov 4, 2024

Intended to address observed errors in C# tests: "KMS response parser error with status 200, error: 'Unexpected: exceeded content length" seemingly caused by multiple HTTP responses returned on the same socket side-by-side.

@kevinAlbs kevinAlbs marked this pull request as ready for review November 5, 2024 20:46
Copy link

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +
A question regarding return in Unknown AWS Operation case for your consideration.

Not strictly needed, but may prevent a similar bug if functions are extended
@kevinAlbs kevinAlbs merged commit d9fb504 into mongodb-labs:master Nov 5, 2024
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants