Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-32078: data class note #132

Merged
merged 14 commits into from
Oct 2, 2023

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Oct 2, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-32078
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin/DOCSP-32078-data-class-note/fundamentals/data-formats/document-data-format-data-class/#specify-component-conversion-using-annotations

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

rustagir and others added 13 commits September 5, 2023 11:15
# Pull Request Info

[PR Reviewing
Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md)

JIRA - https://jira.mongodb.org/browse/DOCSP-31827
Staging -
https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-31827-update-titles/fundamentals/crud/write-operations/modify/

https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-31827-update-titles/fundamentals/crud/write-operations/delete/

Redirects - 
Redirect 301
/docs/drivers/kotlin/coroutine/v4.10/fundamentals/crud/write-operations/change-a-document/
https://www.mongodb.com/docs/drivers/kotlin/coroutine/v4.10/fundamentals/crud/write-operations/modify/
Redirect 301
/docs/drivers/kotlin/coroutine/master/fundamentals/crud/write-operations/change-a-document/
https://www.mongodb.com/docs/drivers/kotlin/coroutine/master/fundamentals/crud/write-operations/modify/


## Self-Review Checklist

- [x] Is this free of any warnings or errors in the RST?
- [ ] Did you run a spell-check?
- [ ] Did you run a grammar-check?
- [x] Are all the links working?
* DOCSP-30911: Add server lifecycle support callout
* 092223: Remove rapid release version from compat table
Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Suggested an alternative presentation of the info to make the description more concise.

Comment on lines 118 to 123
.. note::

Use this annotation only on a property you are
storing as a different BSON type. You might experience errors
if you include the ``BsonRepresentation`` annotation on a
property you are storing as the same type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

I think the current description ("Specifies the BSON type...") could be modified to communicate what's in this callout which would make the content of this description less repetitive.

"Specifies the BSON type MongoDB uses to store the value. Use this annotation only when you need to store the value as a BSON type that differs from the data class property."

And perhaps the callout could be a warning if necessary:

"Your code may throw exceptions If you specify the same type as the data class."

@rustagir rustagir merged commit 0d9d3b0 into mongodb:master Oct 2, 2023
3 of 4 checks passed
@docs-builder-bot
Copy link
Collaborator

ccho-mongodb pushed a commit to ccho-mongodb/docs-kotlin that referenced this pull request Oct 2, 2023
* add vale action

* DOCSP-31827: Update page titles (mongodb#123)

# Pull Request Info

[PR Reviewing
Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md)

JIRA - https://jira.mongodb.org/browse/DOCSP-31827
Staging -
https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-31827-update-titles/fundamentals/crud/write-operations/modify/

https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-31827-update-titles/fundamentals/crud/write-operations/delete/

Redirects - 
Redirect 301
/docs/drivers/kotlin/coroutine/v4.10/fundamentals/crud/write-operations/change-a-document/
https://www.mongodb.com/docs/drivers/kotlin/coroutine/v4.10/fundamentals/crud/write-operations/modify/
Redirect 301
/docs/drivers/kotlin/coroutine/master/fundamentals/crud/write-operations/change-a-document/
https://www.mongodb.com/docs/drivers/kotlin/coroutine/master/fundamentals/crud/write-operations/modify/


## Self-Review Checklist

- [x] Is this free of any warnings or errors in the RST?
- [ ] Did you run a spell-check?
- [ ] Did you run a grammar-check?
- [x] Are all the links working?

* Fix Vale GH action (mongodb#125)

* DOCSP-32483 programmatic tagging script for the kotlin driver repo (mongodb#126)

* DOCSP-30911: Add server lifecycle support callout (mongodb#127)

* DOCSP-30911: Add server lifecycle support callout

* 092123 trivial change to test GH action that copies compat tables (mongodb#128)

* 092123: Fix copy-compat-to-docs-shared action (mongodb#129)

* 092223 compatibility copy (mongodb#130)

* 092223: Remove rapid release version from compat table

* DOCSP-32078: bsonrepresentation note

* column width adjustment

* vale fix

---------

Co-authored-by: Nora Reidy <nora.reidy@mongodb.com>
Co-authored-by: Chris Cho <chris.cho@mongodb.com>
Co-authored-by: Sarah Lin <55722001+sarahemlin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants