-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-32078: data class note #132
DOCSP-32078: data class note #132
Conversation
# Pull Request Info [PR Reviewing Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md) JIRA - https://jira.mongodb.org/browse/DOCSP-31827 Staging - https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-31827-update-titles/fundamentals/crud/write-operations/modify/ https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-31827-update-titles/fundamentals/crud/write-operations/delete/ Redirects - Redirect 301 /docs/drivers/kotlin/coroutine/v4.10/fundamentals/crud/write-operations/change-a-document/ https://www.mongodb.com/docs/drivers/kotlin/coroutine/v4.10/fundamentals/crud/write-operations/modify/ Redirect 301 /docs/drivers/kotlin/coroutine/master/fundamentals/crud/write-operations/change-a-document/ https://www.mongodb.com/docs/drivers/kotlin/coroutine/master/fundamentals/crud/write-operations/modify/ ## Self-Review Checklist - [x] Is this free of any warnings or errors in the RST? - [ ] Did you run a spell-check? - [ ] Did you run a grammar-check? - [x] Are all the links working?
* DOCSP-30911: Add server lifecycle support callout
* 092223: Remove rapid release version from compat table
…s-kotlin into DOCSP-32078-data-class-note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Suggested an alternative presentation of the info to make the description more concise.
.. note:: | ||
|
||
Use this annotation only on a property you are | ||
storing as a different BSON type. You might experience errors | ||
if you include the ``BsonRepresentation`` annotation on a | ||
property you are storing as the same type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
I think the current description ("Specifies the BSON type...") could be modified to communicate what's in this callout which would make the content of this description less repetitive.
"Specifies the BSON type MongoDB uses to store the value. Use this annotation only when you need to store the value as a BSON type that differs from the data class property."
And perhaps the callout could be a warning if necessary:
"Your code may throw exceptions If you specify the same type as the data class."
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/kotlin/master/ 🪵 Logs |
* add vale action * DOCSP-31827: Update page titles (mongodb#123) # Pull Request Info [PR Reviewing Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md) JIRA - https://jira.mongodb.org/browse/DOCSP-31827 Staging - https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-31827-update-titles/fundamentals/crud/write-operations/modify/ https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-31827-update-titles/fundamentals/crud/write-operations/delete/ Redirects - Redirect 301 /docs/drivers/kotlin/coroutine/v4.10/fundamentals/crud/write-operations/change-a-document/ https://www.mongodb.com/docs/drivers/kotlin/coroutine/v4.10/fundamentals/crud/write-operations/modify/ Redirect 301 /docs/drivers/kotlin/coroutine/master/fundamentals/crud/write-operations/change-a-document/ https://www.mongodb.com/docs/drivers/kotlin/coroutine/master/fundamentals/crud/write-operations/modify/ ## Self-Review Checklist - [x] Is this free of any warnings or errors in the RST? - [ ] Did you run a spell-check? - [ ] Did you run a grammar-check? - [x] Are all the links working? * Fix Vale GH action (mongodb#125) * DOCSP-32483 programmatic tagging script for the kotlin driver repo (mongodb#126) * DOCSP-30911: Add server lifecycle support callout (mongodb#127) * DOCSP-30911: Add server lifecycle support callout * 092123 trivial change to test GH action that copies compat tables (mongodb#128) * 092123: Fix copy-compat-to-docs-shared action (mongodb#129) * 092223 compatibility copy (mongodb#130) * 092223: Remove rapid release version from compat table * DOCSP-32078: bsonrepresentation note * column width adjustment * vale fix --------- Co-authored-by: Nora Reidy <nora.reidy@mongodb.com> Co-authored-by: Chris Cho <chris.cho@mongodb.com> Co-authored-by: Sarah Lin <55722001+sarahemlin@users.noreply.github.com>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32078
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin/DOCSP-32078-data-class-note/fundamentals/data-formats/document-data-format-data-class/#specify-component-conversion-using-annotations
Self-Review Checklist