CXX-2785 use read concern majority in test #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read concern local is accepted for aggregate with $listSearchIndexes. To avoid a false positive test, use read concern majority. If the read concern is incorrectly applied to the command, Atlas will return an error.
kkloberdanz
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #1055 to use
majorityread concern instead oflocal.Background & Motivation
The test expects that applying a read concern to the command results in an error from Atlas. It was discovered in the specification PR (mongodb/specifications#1474 (comment)) that
localis accepted for theaggregatewith$listSearchIndexes. To avoid a false positive test, the test now uses read concernmajority. If the driver incorrectly applies the read concern, Atlas returns the error:$listSearchIndexes cannot run with a readConcern other than 'local'. Current readConcern: majority.