Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
qingyang-hu committed Nov 9, 2023
1 parent 994d1dc commit e24905e
Show file tree
Hide file tree
Showing 8 changed files with 34 additions and 9 deletions.
5 changes: 3 additions & 2 deletions event/monitoring.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,9 @@ type PoolEvent struct {
Reason string `json:"reason"`
// ServiceID is only set if the Type is PoolCleared and the server is deployed behind a load balancer. This field
// can be used to distinguish between individual servers in a load balanced deployment.
ServiceID *primitive.ObjectID `json:"serviceId"`
Error error `json:"error"`
ServiceID *primitive.ObjectID `json:"serviceId"`
Interruption bool `json:"interruptInUseConnections"`
Error error `json:"error"`
}

// PoolMonitor is a function that allows the user to gain access to events occurring in the pool
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,7 @@ func executeInsertOne(ctx context.Context, operation *operation) (*operationResu
}

res, err := coll.InsertOne(ctx, document, opts)
fmt.Println("insert one", err)
raw := emptyCoreDocument
if res != nil {
t, data, err := bson.MarshalValue(res.InsertedID)
Expand Down
8 changes: 7 additions & 1 deletion mongo/integration/unified/event_verification.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ type cmapEvent struct {
ConnectionCheckedInEvent *struct{} `bson:"connectionCheckedInEvent"`

PoolClearedEvent *struct {
HasServiceID *bool `bson:"hasServiceId"`
HasServiceID *bool `bson:"hasServiceId"`
InterruptInUseConnections *bool `bson:"interruptInUseConnections"`
} `bson:"poolClearedEvent"`
}

Expand Down Expand Up @@ -353,6 +354,7 @@ func verifyCMAPEvents(client *clientEntity, expectedEvents *expectedEvents) erro
}
case evt.PoolClearedEvent != nil:
var actual *event.PoolEvent
fmt.Println("PoolClearedEvent", evt.PoolClearedEvent, actual)
if actual, pooled, err = getNextPoolEvent(pooled, event.PoolCleared); err != nil {
return newEventVerificationError(idx, client, err.Error())
}
Expand All @@ -361,6 +363,10 @@ func verifyCMAPEvents(client *clientEntity, expectedEvents *expectedEvents) erro
return newEventVerificationError(idx, client, "error verifying serviceID: %v", err)
}
}
if expectInterruption := evt.PoolClearedEvent.InterruptInUseConnections; expectInterruption != nil && *expectInterruption != actual.Interruption {
return newEventVerificationError(idx, client, "expected interruptInUseConnections %v, got %v",
expectInterruption, actual.Interruption)
}
default:
return newEventVerificationError(idx, client, "no expected event set on cmapEvent instance")
}
Expand Down
10 changes: 8 additions & 2 deletions mongo/integration/unified/testrunner_operation.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,14 @@ func executeTestRunnerOperation(ctx context.Context, operation *operation, loopD
}
return nil
case "runOnThread":
// TODO
return nil
operationRaw, err := args.LookupErr("operation")
if err != nil {
return fmt.Errorf("'operation' argument not found in runOnThread operation")
}
if err := operationRaw.Unmarshal(operation); err != nil {
return fmt.Errorf("error unmarshalling 'operation' argument: %v", err)
}
return operation.execute(ctx, loopDone)
case "waitForThread":
// TODO
return nil
Expand Down
4 changes: 4 additions & 0 deletions mongo/integration/unified/unified_spec_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -299,15 +299,18 @@ func (tc *TestCase) Run(ls LoggerSkipper) error {
}
}

fmt.Println("run")
for idx, operation := range tc.Operations {
if err := operation.execute(testCtx, tc.loopDone); err != nil {
fmt.Println("run err", err, operation)
if isSkipTestError(err) {
ls.Skip(err)
}

return fmt.Errorf("error running operation %q at index %d: %v", operation.Name, idx, err)
}
}
fmt.Println("~run")

// Create a validator for log messages and start the workers that will
// observe log messages as they occur operationally.
Expand All @@ -324,6 +327,7 @@ func (tc *TestCase) Run(ls LoggerSkipper) error {
if tc.Description != "BulkWrite on server that doesn't support arrayFilters with arrayFilters on second op" {
for idx, expectedEvents := range tc.ExpectedEvents {
if err := verifyEvents(testCtx, expectedEvents); err != nil {
fmt.Println("verification failed", expectedEvents)
return fmt.Errorf("events verification failed at index %d: %v", idx, err)
}
}
Expand Down
4 changes: 4 additions & 0 deletions x/mongo/driver/topology/connection.go
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,10 @@ func (c *connection) cancellationListenerCallback() {
}

func (c *connection) writeWireMessage(ctx context.Context, wm []byte) error {
// fmt.Println("writeWireMessage")
var err error
if atomic.LoadInt64(&c.state) != connConnected {
fmt.Println("writeWireMessage close")
return ConnectionError{
ConnectionID: c.id,
Wrapped: c.err,
Expand Down Expand Up @@ -392,7 +394,9 @@ func (c *connection) write(ctx context.Context, wm []byte) (err error) {

// readWireMessage reads a wiremessage from the connection. The dst parameter will be overwritten.
func (c *connection) readWireMessage(ctx context.Context) ([]byte, error) {
// fmt.Println("readWireMessage")
if atomic.LoadInt64(&c.state) != connConnected {
fmt.Println("readWireMessage close")
return nil, ConnectionError{
ConnectionID: c.id,
Wrapped: c.err,
Expand Down
10 changes: 6 additions & 4 deletions x/mongo/driver/topology/pool.go
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,7 @@ func (p *pool) checkInNoEvent(conn *connection) error {
}

func (p *pool) interruptInUseConnections() {
fmt.Println("interruptInUseConnections")
for _, conn := range p.conns {
if conn.inUse && p.stale(conn) {
_ = p.removeConnection(conn, reason{
Expand Down Expand Up @@ -944,10 +945,11 @@ func (p *pool) clear(err error, serviceID *primitive.ObjectID, cleaningupFns ...

if sendEvent && p.monitor != nil {
p.monitor.Event(&event.PoolEvent{
Type: event.PoolCleared,
Address: p.address.String(),
ServiceID: serviceID,
Error: err,
Type: event.PoolCleared,
Address: p.address.String(),
ServiceID: serviceID,
Interruption: len(cleaningupFns) > 0,
Error: err,
})
}

Expand Down
1 change: 1 addition & 0 deletions x/mongo/driver/topology/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,7 @@ func (s *Server) update() {
// Clear the pool once the description has been updated to Unknown. Pass in a nil service ID to clear
// because the monitoring routine only runs for non-load balanced deployments in which servers don't return
// IDs.
fmt.Println("clear with interruptInUseConnections", err)
s.pool.clear(err, nil, s.pool.interruptInUseConnections)
}
// We're either not handling a timeout error, or we just handled the 2nd consecutive
Expand Down

0 comments on commit e24905e

Please sign in to comment.