Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2923 Fix remote handling #1348

Merged
merged 9 commits into from
Aug 11, 2023
Merged

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 11, 2023

GODRIVER-2923

Summary

Fix handling of the API Report for PRs made from a fork.

Background & Motivation

The previous PR was tested using PRs from the same repo (my own fork).

@blink1073 blink1073 closed this Aug 11, 2023
@blink1073 blink1073 reopened this Aug 11, 2023
@blink1073
Copy link
Member Author

blink1073 commented Aug 11, 2023

Okay, I think this won't run until we merge it, because I changed the trigger type. The pull_request type does not allow making a GitHub API call as part of the workflow, which the PR comment requires.

@blink1073 blink1073 marked this pull request as ready for review August 11, 2023 00:50
@blink1073 blink1073 requested a review from a team as a code owner August 11, 2023 00:50
@blink1073 blink1073 requested review from qingyang-hu and removed request for a team August 11, 2023 00:50
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit 13004f7 into mongodb:master Aug 11, 2023
@blink1073 blink1073 deleted the GODRIVER-2923-2 branch August 11, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants