Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2943 Skip failing logging tests #1350

Merged
merged 6 commits into from
Aug 16, 2023
Merged

GODRIVER-2943 Skip failing logging tests #1350

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb7629f
GODRIVER-2943 Fix failing logging tests
blink1073 Aug 15, 2023
c11840e
syntax
blink1073 Aug 15, 2023
557ae60
formatting and case
blink1073 Aug 15, 2023
84324b0
try again
blink1073 Aug 15, 2023
44df297
proper skip
blink1073 Aug 16, 2023
dd381e6
cleanup
blink1073 Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mongo/integration/unified_spec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const (
spec1403SkipReason = "servers less than 4.2 do not have mongocryptd; see SPEC-1403"
godriver2123SkipReason = "failpoints and timeouts together cause failures; see GODRIVER-2123"
godriver2413SkipReason = "encryptedFields argument is not supported on Collection.Drop; see GODRIVER-2413"
godriver2943SkipReason = "logging test is failing"
)

var (
Expand All @@ -61,6 +62,7 @@ var (
"CreateCollection from encryptedFields.": godriver2413SkipReason,
"DropCollection from encryptedFields": godriver2413SkipReason,
"DropCollection from remote encryptedFields": godriver2413SkipReason,
"Topology LifeCycle": godriver2943SkipReason,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a description of "Topology LifeCycle" used in any spec test?
Also, did you run the "go fmt" to help align the key-value pair? EG "static-analysis" is complaining about the format. You may find some IDE plugins to format the lines automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it should be Topology lifecycle:

mongo/integration/unified_spec_test.go:             "Topology lifecycle":                               godriver2943SkipReason,
testdata/server-discovery-and-monitoring/unified/logging-loadbalanced.json:      "description": "Topology lifecycle",
testdata/server-discovery-and-monitoring/unified/logging-loadbalanced.yml:  - description: "Topology lifecycle"
testdata/server-discovery-and-monitoring/unified/logging-replicaset.json:      "description": "Topology lifecycle",
testdata/server-discovery-and-monitoring/unified/logging-replicaset.yml:  - description: "Topology lifecycle"
testdata/server-discovery-and-monitoring/unified/logging-sharded.json:      "description": "Topology lifecycle",
testdata/server-discovery-and-monitoring/unified/logging-sharded.yml:  - description: "Topology lifecycle"
testdata/server-discovery-and-monitoring/unified/logging-standalone.json:      "description": "Topology lifecycle",
testdata/server-discovery-and-monitoring/unified/logging-standalone.yml:  - description: "Topology lifecycle"

}
)

Expand Down
Loading