-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2962 Remove setters from AbortTransaction and CommitTransaction. #1363
GODRIVER-2962 Remove setters from AbortTransaction and CommitTransaction. #1363
Conversation
853c561
to
8305771
Compare
API Change Report./x/mongo/driver/operationincompatible changes(*AbortTransaction).ClusterClock: removed compatible changesAbortTransaction.Clock: added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The base branch was changed.
036e119
to
cd62689
Compare
Should this also be on the 2.0 epic? |
Not sure what's going on with the tests, but this isn't important to complete right now. I'm closing this for now, will revisit later. |
@blink1073 No, these can go in any release because they're unstable API. I switched them to |
GODRIVER-2962
Summary
Remove setters from
AbortTransaction
andCommitTransaction
.Background & Motivation
The field setters on the operation types in the
x/mongo/driver/operation
package provide no usability improvement but create a maintenance burden whenever we have to update the operations. Remove the field setters and use struct literals instead.Split the change into multiple PRs to make reviewing them easier.