Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2958 Use AWS Secrets for Atlas tests #1365

Merged
merged 12 commits into from
Sep 1, 2023

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 29, 2023

GODRIVER-2958

Summary

Use AWS Secrets for variables instead of Evergreen project variables for Atlas tests.

Background & Motivation

Centralizes location of secrets and allows them to be accessed for local development.

@blink1073
Copy link
Member Author

Depends on mongodb-labs/drivers-evergreen-tools#344

@blink1073 blink1073 temporarily deployed to api-report August 29, 2023 18:39 — with GitHub Actions Inactive
@blink1073 blink1073 marked this pull request as ready for review August 29, 2023 18:39
@blink1073 blink1073 requested a review from a team as a code owner August 29, 2023 18:39
@blink1073 blink1073 requested review from matthewdale and removed request for a team August 29, 2023 18:39
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

API Change Report

No changes found!

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Makefile simplification! Looks good 👍

@blink1073 blink1073 merged commit 02d5139 into mongodb:master Sep 1, 2023
18 of 21 checks passed
@blink1073 blink1073 deleted the GODRIVER-2958 branch September 1, 2023 11:06
qingyang-hu pushed a commit that referenced this pull request Nov 8, 2023
* GODRIVER-2958 Use AWS Secrets for Atlas tests

* fix handling of shell

* fix cleanup

* print finished

* try wip branch

* cleanup

* cleanup

* cleanup

* cleanup

* clean up secrets handling

* GODRIVER-2958 Use AWS Secrets for Atlas tests

* restore drivers-eg-tools checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants