-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2966 Remove the heartbeat events after a connection is closed / a check is canceled. #1378
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8ca1f20
GODRIVER-2966Remove the ServerHeartbeatStartedEvent after a connectio…
qingyang-hu 21f9d2d
GODRIVER-2966Remove unnecessary server heartbeat events.
qingyang-hu b5acc29
Increase timeout
qingyang-hu 2c7ed05
minor fix
qingyang-hu eb7d5d3
fix logging tests
qingyang-hu 26368d8
Use 0 for nil connection.
qingyang-hu 7944564
Enable "SucceededEvent" and "FailedEvent" on nil conn.
qingyang-hu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -795,12 +795,15 @@ func (s *Server) check() (description.Server, error) { | |
var duration time.Duration | ||
|
||
start := time.Now() | ||
|
||
// Create a new connection if this is the first check, the connection was closed after an error during the previous | ||
// check, or the previous check was cancelled. | ||
if s.conn == nil || s.conn.closed() || s.checkWasCancelled() { | ||
// Create a new connection if this is the first check, the connection was closed after an error during the previous | ||
// check, or the previous check was cancelled. | ||
connID := "0" | ||
if s.conn != nil { | ||
s.publishServerHeartbeatStartedEvent(s.conn.ID(), false) | ||
connID = s.conn.ID() | ||
} | ||
s.publishServerHeartbeatStartedEvent(connID, false) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should do something similar for the subsequent |
||
// Create a new connection and add it's handshake RTT as a sample. | ||
err = s.setupHeartbeatConnection() | ||
duration = time.Since(start) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A connection ID of
"0"
doesn't match the existing pattern of"<addr>[-<number>]"
(see here). Using an empty string seems more correct for when the connection is nil.