GODRIVER-2981 API comment doesn't work when job approver isn't PR author #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested review from
prestonvasquez
and removed request for
a team
blink1073
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
approved these changes
Sep 14, 2023
blink1073
had a problem deploying
to
api-report
GitHub Actions
Failure
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I'm going to re-target this PR to v1. |
blink1073
had a problem deploying
to
api-report
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2981
Summary
Use the owner of the repository when running the workflow. Only request the workflow run when a review is requested.
Background & Motivation
Allows the workflow to be run for someone else's PR, and reduces GitHub notification noise.