Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2046 Return clearer error when truncating a float64 to float32 without the truncate tag #1448

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ehershey
Copy link
Contributor

@ehershey ehershey commented Nov 1, 2023

GODRIVER-2046

Summary

Update error text.

Background & Motivation

Just ran into this today and it caused me a little friction. It seems like a simple enough fix.

@ehershey ehershey requested a review from a team as a code owner November 1, 2023 20:01
@ehershey ehershey requested review from qingyang-hu and removed request for a team November 1, 2023 20:01
Copy link
Contributor

API Change Report

./mongo/options

incompatible changes

(*ClientOptions).SetServerMonitoringMode: removed
ClientOptions.ServerMonitoringMode: removed
ServerMonitoringModeAuto: removed
ServerMonitoringModePoll: removed
ServerMonitoringModeStream: removed

./x/mongo/driver/connstring

incompatible changes

ConnString.ServerMonitoringMode: removed
IsValidServerMonitoringMode: removed
ServerMonitoringModeAuto: removed
ServerMonitoringModePoll: removed
ServerMonitoringModeStream: removed

@prestonvasquez prestonvasquez requested review from prestonvasquez and removed request for qingyang-hu November 1, 2023 20:39
@prestonvasquez prestonvasquez merged commit 4f44ebf into mongodb:v1 Nov 1, 2023
32 of 35 checks passed
blink1073 pushed a commit to blink1073/mongo-go-driver that referenced this pull request Nov 1, 2023
…32 without the truncate tag (mongodb#1448)

(cherry picked from commit 4f44ebf)
@ehershey ehershey deleted the GODRIVER-2046-v1 branch November 1, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants