GODRIVER-2649 Remove RW Concern Logic from RunCommand #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested review from
blink1073
and removed request for
a team
prestonvasquez
force-pushed
the
GODRIVER-2649
branch
from
e199a23
to
9208f05
Compare
API Change Report./x/mongo/driver/operationincompatible changes(*Command).ReadConcern: removed |
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Nov 3, 2023
(cherry picked from commit d52c9e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2649
Summary
Remove unused readConcern setter for commands at the mongo and x/opereration levels. Per the specifications:
Background & Motivation
This ticket originally proposed to "pass readConcern to the underlying [command] operation". However, this is prohibited in the DBX specifications.
This change is not backwards breaking since we do not honor the passed Database.readConcern as-is. This change should be part of the next minor release.