Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-3050 Ignore the case for the UNIX socket filename. #1460

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

qingyang-hu
Copy link
Collaborator

@qingyang-hu qingyang-hu commented Nov 7, 2023

GODRIVER-3050 (GODRIVER-2949)

Summary

Ignore the case for the UNIX socket filename.

Background & Motivation

If the address is a UNIX socket file, it should be case-sensitive.

This PR may be a breaking change, so we'd better only merge it into v2.0.

Copy link
Contributor

mongodb-drivers-pr-bot bot commented Nov 7, 2023

API Change Report

No changes found!

@qingyang-hu qingyang-hu changed the title GODRIVER-2949 Ignore address case. GODRIVER-2949 Ignore the case for the UNIX socket filename. Nov 7, 2023
@qingyang-hu qingyang-hu marked this pull request as ready for review December 8, 2023 15:37
@qingyang-hu qingyang-hu requested a review from a team as a code owner December 8, 2023 15:37
@qingyang-hu qingyang-hu requested review from prestonvasquez and removed request for a team December 8, 2023 15:37
@qingyang-hu qingyang-hu changed the title GODRIVER-2949 Ignore the case for the UNIX socket filename. GODRIVER-3050 Ignore the case for the UNIX socket filename. Dec 8, 2023
@blink1073 blink1073 requested review from blink1073 and removed request for prestonvasquez December 8, 2023 18:04
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingyang-hu qingyang-hu merged commit 6ddf780 into mongodb:master Dec 11, 2023
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants