GODRIVER-2719 Remove unnecessary errors from bson.Encoder/bson.Decoder.
#1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change Report./bsonincompatible changes##NewDecoder: changed from func(./bson/bsonrw.ValueReader) (*Decoder, error) to func(./bson/bsonrw.ValueReader) *Decoder ./bson/bsonrwincompatible changesNewBSONDocumentReader: removed compatible changesNewValueReader: added |
qingyang-hu
force-pushed
the
godriver2719
branch
from
9b6f078
to
5c6ae7e
Compare
qingyang-hu
force-pushed
the
godriver2719
branch
4 times, most recently
from
b770d14
to
642f3b0
Compare
qingyang-hu
requested review from
prestonvasquez and
matthewdale
and removed request for
a team
qingyang-hu
changed the title
bson.Encoder\bson.Decoder.bson.Encoder/bson.Decoder.
qingyang-hu
force-pushed
the
godriver2719
branch
from
642f3b0
to
d2dcd1a
Compare
qingyang-hu
force-pushed
the
godriver2719
branch
from
d2dcd1a
to
e5888a5
Compare
prestonvasquez
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2719
Summary
bson.NewEncoder/bson.NewDecoderandNew*ValueWriter/New*ValueReader.bson.NewBSONValueWritertobson.NewValueWriter.NewBSONDocumentReadertoNewValueReader.NewBSONValueReader.Background & Motivation
The PR proposes to let subsequent calls panic with a "nil pointer dereference" rather than panic explicitly for nil function arguments as the ticket description suggests because 1, it is what the Go "encoding/json" library does; 2, it is will be difficult to maintain the consistency of the panic information/style.