GODRIVER-3040 [master] Add driver tests for Serverless Proxy incremental rollout #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut (mongodb#1473) (cherry picked from commit 134d007)
blink1073
requested review from
prestonvasquez
and removed request for
a team
API Change ReportNo changes found! |
.evergreen/config.yml
Outdated
| SERVERLESS_API_PRIVATE_KEY=${SERVERLESS_API_PRIVATE_KEY} \ | ||
| SERVERLESS_INSTANCE_NAME=${SERVERLESS_INSTANCE_NAME} \ | ||
| bash ${DRIVERS_TOOLS}/.evergreen/serverless/delete-instance.sh | ||
| bash ${DRIVERS_TOOLS}/.evergreen/serverless/delete-instance.sh ${VAULT_NAME} |
There was a problem hiding this comment.
Looking at the code for delete-instance.sh , I don't see what the VAULT_NAME does here. Is this in anticipation of a future update to the delete-instance.sh script?
There was a problem hiding this comment.
Yeah, good catch, it isn't needed.
prestonvasquez
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1473 from v1 to master