Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go mod tidy before vendoring in compilecheck. #1620

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

matthewdale
Copy link
Collaborator

Summary

Run go mod tidy before go mod vendor in the compile check script.

Background & Motivation

Github Dependabot PRs that update dependencies (e.g. #1619) fail the build check while running etc/compile_check.sh because of error:

+ GC=go
+ COMPILE_CHECK_DIR=internal/test/compilecheck
+ DEV_MIN_VERSION=1.19
+ compile_check
+ cd internal/test/compilecheck
+ go mod vendor
go: updates to go.mod needed; to update it:
        go mod tidy

That is caused by running go mod vendor after changing some dependency version in the go.mongodb.org/mongo-driver module. We already run go mod tidy later in the script, but need to run it earlier to avoid the above error.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Apr 25, 2024
Copy link
Contributor

API Change Report

No changes found!

@matthewdale matthewdale merged commit 0a49689 into mongodb:v1 Apr 25, 2024
27 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants