GODRIVER-3333 Fix default auth source for auth specified via ClientOptions [master] #1798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3215
Summary
ClientOptions
to a new functiontopology.NewAuthenticator
. Use it everywhere that needs to create an authenticator fromClientOptions
.convertOIDCArgs
into thetopology
package.topology.NewConfigWithAuthenticator
, but actually has no effect currently, so no default auth sources are being set.Background & Motivation
Currently, if auth mechanism "MONGODB-AWS" is set using
ClientOptions.SetAuth
, the default auth source is set to "admin" instead of "$external". The result is a confusing error messageThere was a further regression (that hasn't been released yet) caused by #1678, which effectively skips all of the default auth source logic. Refactor the authenticator creation logic and the default auth source logic to make similar regressions more obvious.