Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-3313 Skip CSOT spec tests on Windows and macOS. #1818

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented Sep 17, 2024

GODRIVER-3313

Summary

  • Add logic to skip all CSOT spec and prose tests if the SKIP_CSOT_TESTS environment variable is set to "true".
  • Set the SKIP_CSOT_TESTS=true environment variable on Windows and macOS CI tasks.

Background & Motivation

The timings are not as predictable on these platforms, leading to intermittent failures.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Sep 17, 2024
Copy link
Contributor

API Change Report

No changes found!

@matthewdale matthewdale marked this pull request as ready for review September 19, 2024 01:32
@matthewdale
Copy link
Collaborator Author

matthewdale commented Sep 21, 2024

drivers-pr-bot please backport to release/1.17

@matthewdale matthewdale merged commit 8192e81 into mongodb:v1 Sep 21, 2024
31 of 33 checks passed
Copy link
Contributor

Sorry, unable to cherry-pick to master, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout -b cherry-pick-master-8192e810e341abdae37b50e596c4f05b51992691 master

git fetch origin 8192e810e341abdae37b50e596c4f05b51992691
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 8192e810e341abdae37b50e596c4f05b51992691
  1. You will likely have some merge/cherry-pick conflicts here, fix them and commit:
git commit -am {message}
  1. Push to a named branch:
git push origin cherry-pick-master-8192e810e341abdae37b50e596c4f05b51992691
  1. Create a PR against branch master. I would have named this PR:

"GODRIVER-3313 Skip CSOT spec tests on Windows and macOS. (#1818) [master]"

matthewdale added a commit to matthewdale/mongo-go-driver that referenced this pull request Sep 28, 2024
blink1073 pushed a commit to blink1073/mongo-go-driver that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants