Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPC-2421, PHPC-2428: Update bundled dependencies #1622

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Aug 28, 2024

PHPC-2421 updates libmongocrypt to 1.11.0
For PHPC-2428 updating libmongoc to the latest 1.28-dev version pulls in the necessary fixes.

@alcaeus alcaeus requested a review from GromNaN August 28, 2024 12:25
@alcaeus alcaeus self-assigned this Aug 28, 2024
@@ -177,6 +177,7 @@ if (PHP_MONGODB != "no") {
// TODO: Support building with Secure Channel on Windows
MONGOC_ENABLE_SSL_SECURE_CHANNEL: 0,
MONGOC_ENABLE_CRYPTO_CNG: 0,
MONGOC_HAVE_BCRYPT_PBKDF2: 0,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at CMakeLists for libmongoc, this is only used on Windows when MONGOC_ENABLE_CRYPTO_CNG is used. Since we don't support building with secure channel on Windows, we can leave this disabled without checking for it: https://github.com/mongodb/mongo-c-driver/pull/1684/files#diff-e0da4e929ea7d93528029a4c5d5bc77c7c7218fa6328628c100c8c7dc2ed5ffaR536

@alcaeus alcaeus merged commit da39d53 into mongodb:master Aug 29, 2024
72 checks passed
@alcaeus alcaeus deleted the update-libmongoc-libmongocrypt branch August 29, 2024 07:24
alcaeus added a commit that referenced this pull request Sep 4, 2024
* master: (22 commits)
  PHPC-2434: Add PHP 8.4 to GitHub Actions (#1625)
  PHPC-2421, PHPC-2428: Update bundled dependencies (#1622)
  Don't build libmongoc version in pull requests
  Use drivers-evergreen-tools for Windows testing (#1615)
  PHPC-1957 Add tests for out-of-range UTCDateTime values (#1614)
  PHPC-2286 Implement `UTCDateTime::toDateTimeImmutable` (#1611)
  PHPC-2414, PHPC-2415: Update wire versions for MongoDB 8.0 compatibility (#1610)
  PHPC-2349, PHPC-2411: Deprecate unused exception classes (#1608)
  Fix failing tests on x86 systems (#1609)
  PHPC-2347: Deprecate BSON functions (#1607)
  PHPC-1489: Deprecate integer readPreference constants (#1604)
  Fix version computation for libmongoc development versions (#1599)
  PHPC-2376: Test against MongoDB 8.0 (#1598)
  PHPC-2254: Relax server selection timeout error message pattern (#1587)
  PHPC-2401: Support QEv2 range protocol (#1583)
  PHPC-2398: Use server_id methods for libmongoc 1.28+ (#1582)
  PHPC-2395: Fetch Atlas connectivity URIs from AWS Secrets Manager (#1579)
  Merge v1.19 into master (#1578)
  Revert "Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568)" (#1571)
  Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants