PHPC-2420: Initial composer.json for pie support #1624
Conversation
alcaeus
changed the title
| { | ||
| "name": "with-mongodb-client-side-encryption", | ||
| "description": "Enable client-side encryption (auto/yes/no)", | ||
| "needs-value": true |
There was a problem hiding this comment.
Noted that there is no way to specify a default value. Php\Pie\ConfigureOption appears to be where the parsing for this object lives.
There was a problem hiding this comment.
@asgrim confirmed that configure options are only passed to configure if they are explicitly given during the installation process. Thus, the default is implicitly applied by our configuration scripts. As I understand it, this is different from pecl which always passes the configured flags and relies on the defined default value when the user does not input their own value.
There was a problem hiding this comment.
Got it. I was worried needs-value: true would require all of these options to be specified at the time of package installation. Rather, it just requires a value iff the user specifies the option. That sounds like an improvement over PECL.
| @@ -0,0 +1,72 @@ | |||
| { | |||
| "name": "mongodb/mongodb-extension", | |||
There was a problem hiding this comment.
Would "mongodb/mongodb" conflict with PHPLIB, even though the package type differs ("php-ext" vs. "library")? I suppose I'm asking whether the pie packages will share the same namespace with everything else in Packagist.
There was a problem hiding this comment.
Indeed, extensions and packages all share the same namespace, so we can't choose mongodb/mongodb as a name.
| @@ -0,0 +1,72 @@ | |||
| { | |||
There was a problem hiding this comment.
I spent a while getting pie running locally (had to chase down missing extensions for azjezz/psl) just to find out that it doesn't support a validate command to check this JSON file. Well, at least I'll have it ready for future use 🤷
There was a problem hiding this comment.
I'll use the opportunity to summon @asgrim, as they'd be in a better place to give you an idea of if and when to expect a pie validate command.
There was a problem hiding this comment.
You can actually just use composer validate; the schema for the php-ext bit is actually built in there.
| } | ||
| ] | ||
| } | ||
| } |
PHPC-2420
Note: pie support is experimental. No support will be given for installation issues with pie. The integration with pie is mainly done to be able test pie itself.
This is an initial version of a composer.json file to be used with pie. Once this PR has been merged to master, we can add the extension to packagist; after tagging a release we can install the extension using pie.