Update GitHub Actions job names #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
update-clang-job-name
branch
from
43cf1ae
to
3a661a1
Compare
alcaeus
changed the title
alcaeus
force-pushed
the
update-clang-job-name
branch
from
3a661a1
to
18c6c4b
Compare
GromNaN
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
LGTM. The other ways of retrieving the PHP version are not suitable for this project.
This was referenced Sep 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the matrix strategy, as using it will include the PHP version in the name of the job, making it more difficult to have required check across branches. By setting it as an env var, we can avoid duplication as well have a consistent name for the checks after changing the PHP requirement in #1631.