Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPC-2442: Deprecate getServer, add getHost and getPort to APM events #1644

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Sep 11, 2024

https://jira.mongodb.org/browse/PHPC-2442

Also updates initial array size for debug output and reorders output fields.

@jmikola jmikola changed the base branch from v1.x to v1.20 September 11, 2024 15:17
@jmikola jmikola force-pushed the 1.20-phpc-2442 branch 2 times, most recently from e92961d to b2b9c91 Compare September 11, 2024 18:11
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for extracting getServer tests to separate files.

I left a small nit about the comments in the class files, but feel free to ignore.

src/MongoDB/Monitoring/CommandFailedEvent.c Outdated Show resolved Hide resolved
@jmikola jmikola merged commit 1869a72 into mongodb:v1.20 Sep 16, 2024
82 checks passed
@jmikola jmikola deleted the 1.20-phpc-2442 branch September 16, 2024 01:50
This was referenced Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants