PHPC-2444: Remove support for string arguments in UTCDateTime constructor #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Sep 18, 2024
| } | ||
|
|
||
| phongo_throw_exception(PHONGO_ERROR_INVALID_ARGUMENT, "Expected integer or string, %s given", PHONGO_ZVAL_CLASS_OR_TYPE_NAME_P(milliseconds)); | ||
| phongo_throw_exception(PHONGO_ERROR_INVALID_ARGUMENT, "Expected integer or object, %s given", PHONGO_ZVAL_CLASS_OR_TYPE_NAME_P(milliseconds)); |
There was a problem hiding this comment.
Odd that "object" was never included in the original message. Looks like that dates back to 8d7e358.
| @@ -26,20 +26,13 @@ echo throws(function() { | |||
| ?> | |||
| ===DONE=== | |||
| <?php exit(0); ?> | |||
| --EXPECTF-- | |||
| Deprecated: MongoDB\BSON\UTCDateTime::__construct(): Creating a MongoDB\BSON\UTCDateTime instance with a string is deprecated and will be removed in ext-mongodb 2.0 in %s | |||
| --EXPECT-- | |||
There was a problem hiding this comment.
This test appears entirely redundant in light of bson-utcdatetime-008.phpt, but I think both can be deleted in favor of bson-utcdatetime_error-004.phpt
| @@ -21,7 +21,7 @@ foreach ($invalidValues as $invalidValue) { | |||
| <?php exit(0); ?> | |||
| --EXPECT-- | |||
| OK: Got MongoDB\Driver\Exception\InvalidArgumentException | |||
| Expected integer or string, bool given | |||
| Expected integer or object, bool given | |||
There was a problem hiding this comment.
This test file looks perfectly serviceable to add a case for a numeric string. I don't think we need to bother with testing a non-numeric string since it'd just trigger the same code path in the constructor.
I'd suggest removing both of the other test files and adding to the comment about $invalidValues above to explain why you're using a numeric string (previously supported but now we require Int64, yada yada).
alcaeus
force-pushed
the
phpc-2444-remove-utcdatetime-string-argument
branch
from
5d8643a
to
2057018
Compare
alcaeus
force-pushed
the
phpc-2444-remove-utcdatetime-string-argument
branch
2 times, most recently
from
3a8a430
to
b47023a
Compare
jmikola
approved these changes
Sep 19, 2024
alcaeus
force-pushed
the
phpc-2444-remove-utcdatetime-string-argument
branch
from
b47023a
to
4739a6c
Compare
alcaeus
added a commit
that referenced
this pull request
Oct 29, 2024
* v2.x: (22 commits) PHPC-2441: Remove deprecated Manager constructor options (#1719) PHPC-990: Strict type validation for boolean URI options (#1713) PHPC-2440: Remove deprecated Query constructor options (#1707) PHPC-2459: Remove support for float arg in UTCDateTime ctor (#1709) Remove obsolete test PHPC-2344 Remove SSLConnectionException (#1696) PHPC-2144 Throw a LogicException when getting info from unacknowledged write result (#1687) PHPC-2454: Remove --enable-system-ciphers configure option (#1681) PHPC-2348 Remove `WriteException` and move `getWriteResult` to `BulkWriteException` (#1685) PHPC-2417 Add UTCDateTimeInterface::toDateTimeImmutable() (#1684) PHPC-2309: Remove --with-openssl-dir configure option (#1676) PHPC-2444: Remove support for string arguments in UTCDateTime constructor (#1662) PHPC-2248: Remove Serializable implementations (#1663) Update version for 2.x branch (#1672) PHPC-1021: Remove support for ReadPreference integer modes (#1666) PHPC-2342: Remove --with-libbson and --with-libmongoc configure options (#1667) PHPC-2351: Remove CursorId class (#1664) PHPC-2140: Make tentative return types definitive (#1658) PHPC-2402: Remove range_preview constants (#1665) PHPC-2346: Remove deprecated BSON functions (#1653) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2444