PHPC-2448: Update to libmongoc 1.28.0 #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Sep 20, 2024
| @@ -1,52 +1,52 @@ | |||
| { | |||
| "components": [ | |||
| { | |||
| "bom-ref": "pkg:github/mongodb/libmongocrypt@1.10.1", | |||
| "bom-ref": "pkg:github/mongodb/libmongocrypt@1.11.0", | |||
There was a problem hiding this comment.
I assume this was missed in da39d53.
I noted that we have Update SBOM file in the contributing docs, but I likely would have forgotten to do this myself.
Is it feasible to try and catch this in CI? Having it checked before allowing a release would be sufficient, as there's likely no harm in it being temporarily out of sync for the development branch.
There was a problem hiding this comment.
Good point. I filed PHPC-2450 to track this.
This was referenced Sep 23, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2448