Fix types accepted by $round

mongodb · Sep 13, 2024 · 4426cf0 · 4426cf0
1 parent 0ed8dff
commit 4426cf0
Show file tree

Hide file tree

Showing 5 changed files with 59 additions and 13 deletions.
diff --git a/generator/config/expression/round.yaml b/generator/config/expression/round.yaml
@@ -8,15 +8,12 @@ type:
  - resolvesToLong
 encode: array
 description: |
- Rounds a number to to a whole integer or to a specified decimal place.
+ Rounds a number to a whole integer or to a specified decimal place.
 arguments:
  -
  name: number
  type:
- - resolvesToInt
- - resolvesToDouble
- - resolvesToDecimal
- - resolvesToLong
+ - resolvesToNumber
  description: |
  Can be any valid expression that resolves to a number. Specifically, the expression must resolve to an integer, double, decimal, or long.
  $round returns an error if the expression resolves to a non-numeric data type.
@@ -38,3 +35,14 @@ tests:
  $round:
  - '$value'
  - 1
+ -
+ name: 'Round Average Rating'
+ pipeline:
+ -
+ $project:
+ roundedAverageRating:
+ $round:
+ -
+ $avg:
+ - '$averageRating'
+ - 2
diff --git a/src/Builder/Expression/FactoryTrait.php b/src/Builder/Expression/FactoryTrait.php
diff --git a/src/Builder/Expression/RoundOperator.php b/src/Builder/Expression/RoundOperator.php
diff --git a/tests/Builder/Expression/Pipelines.php b/tests/Builder/Expression/Pipelines.php
diff --git a/tests/Builder/Expression/RoundOperatorTest.php b/tests/Builder/Expression/RoundOperatorTest.php
@@ -27,4 +27,20 @@ public function testExample(): void
 
  $this->assertSamePipeline(Pipelines::RoundExample, $pipeline);
  }
+
+ public function testRoundAverageRating(): void
+ {
+ $pipeline = new Pipeline(
+ Stage::project(
+ roundedAverageRating: Expression::round(
+ Expression::avg(
+ Expression::doubleFieldPath('averageRating'),
+ ),
+ 2,
+ ),
+ ),
+ );
+
+ $this->assertSamePipeline(Pipelines::RoundRoundAverageRating, $pipeline);
+ }
 }