Insert fixture through factory in test object

mongodb · Jul 31, 2023 · 82a68e8 · 82a68e8
1 parent 48889a9
commit 82a68e8
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 24 deletions.
diff --git a/tests/Collection/CodecCollectionFunctionalTest.php b/tests/Collection/CodecCollectionFunctionalTest.php
@@ -505,10 +505,7 @@ private function createFixtures(int $n, array $executeBulkWriteOptions = []): vo
         $bulkWrite = new BulkWrite(['ordered' => true]);
 
         for ($i = 1; $i <= $n; $i++) {
-            $bulkWrite->insert([
-                '_id' => $i,
-                'x' => (object) ['foo' => 'bar'],
-            ]);
+            $bulkWrite->insert(TestObject::createDocument($i));
         }
 
         $result = $this->manager->executeBulkWrite($this->getNamespace(), $bulkWrite, $executeBulkWriteOptions);

diff --git a/tests/Fixtures/Document/TestObject.php b/tests/Fixtures/Document/TestObject.php
@@ -17,6 +17,8 @@
 
 namespace MongoDB\Tests\Fixtures\Document;
 
+use MongoDB\BSON\Document;
+
 final class TestObject
 {
     public int $id;
@@ -25,6 +27,14 @@ final class TestObject
 
     public bool $decoded = false;
 
+    public static function createDocument(int $id): Document
+    {
+        return Document::fromPHP([
+            '_id' => $id,
+            'x' => ['foo' => 'bar'],
+        ]);
+    }
+
     public static function createForFixture(int $id): self
     {
         $instance = new self();

diff --git a/tests/Operation/AggregateFunctionalTest.php b/tests/Operation/AggregateFunctionalTest.php
@@ -369,10 +369,7 @@ private function createFixtures(int $n, array $executeBulkWriteOptions = []): vo
         $bulkWrite = new BulkWrite(['ordered' => true]);
 
         for ($i = 1; $i <= $n; $i++) {
-            $bulkWrite->insert([
-                '_id' => $i,
-                'x' => (object) ['foo' => 'bar'],
-            ]);
+            $bulkWrite->insert(TestObject::createDocument($i));
         }
 
         $result = $this->manager->executeBulkWrite($this->getNamespace(), $bulkWrite, $executeBulkWriteOptions);

diff --git a/tests/Operation/FindAndModifyFunctionalTest.php b/tests/Operation/FindAndModifyFunctionalTest.php
@@ -334,10 +334,7 @@ private function createFixtures(int $n): void
         $bulkWrite = new BulkWrite(['ordered' => true]);
 
         for ($i = 1; $i <= $n; $i++) {
-            $bulkWrite->insert([
-                '_id' => $i,
-                'x' => (object) ['foo' => 'bar'],
-            ]);
+            $bulkWrite->insert(TestObject::createDocument($i));
         }
 
         $result = $this->manager->executeBulkWrite($this->getNamespace(), $bulkWrite);

diff --git a/tests/Operation/FindFunctionalTest.php b/tests/Operation/FindFunctionalTest.php
@@ -323,10 +323,7 @@ private function createFixtures(int $n, array $executeBulkWriteOptions = []): vo
         $bulkWrite = new BulkWrite(['ordered' => true]);
 
         for ($i = 1; $i <= $n; $i++) {
-            $bulkWrite->insert([
-                '_id' => $i,
-                'x' => (object) ['foo' => 'bar'],
-            ]);
+            $bulkWrite->insert(TestObject::createDocument($i));
         }
 
         $result = $this->manager->executeBulkWrite($this->getNamespace(), $bulkWrite, $executeBulkWriteOptions);

diff --git a/tests/Operation/FindOneAndReplaceFunctionalTest.php b/tests/Operation/FindOneAndReplaceFunctionalTest.php
@@ -53,10 +53,7 @@ private function createFixtures(int $n): void
         $bulkWrite = new BulkWrite(['ordered' => true]);
 
         for ($i = 1; $i <= $n; $i++) {
-            $bulkWrite->insert([
-                '_id' => $i,
-                'x' => (object) ['foo' => 'bar'],
-            ]);
+            $bulkWrite->insert(TestObject::createDocument($i));
         }
 
         $result = $this->manager->executeBulkWrite($this->getNamespace(), $bulkWrite);

diff --git a/tests/Operation/FindOneFunctionalTest.php b/tests/Operation/FindOneFunctionalTest.php
@@ -58,10 +58,7 @@ private function createFixtures(int $n): void
         $bulkWrite = new BulkWrite(['ordered' => true]);
 
         for ($i = 1; $i <= $n; $i++) {
-            $bulkWrite->insert([
-                '_id' => $i,
-                'x' => (object) ['foo' => 'bar'],
-            ]);
+            $bulkWrite->insert(TestObject::createDocument($i));
         }
 
         $result = $this->manager->executeBulkWrite($this->getNamespace(), $bulkWrite);