Fix types accepted by $round (#1401)

mongodb · Sep 16, 2024 · f2842bc · f2842bc
1 parent 7093d9b
commit f2842bc
Show file tree

Hide file tree

Showing 5 changed files with 67 additions and 13 deletions.
diff --git a/generator/config/expression/round.yaml b/generator/config/expression/round.yaml
@@ -8,15 +8,12 @@ type:
     - resolvesToLong
 encode: array
 description: |
-    Rounds a number to to a whole integer or to a specified decimal place.
+    Rounds a number to a whole integer or to a specified decimal place.
 arguments:
     -
         name: number
         type:
-            - resolvesToInt
-            - resolvesToDouble
-            - resolvesToDecimal
-            - resolvesToLong
+            - resolvesToNumber
         description: |
             Can be any valid expression that resolves to a number. Specifically, the expression must resolve to an integer, double, decimal, or long.
             $round returns an error if the expression resolves to a non-numeric data type.
@@ -38,3 +35,16 @@ tests:
                         $round:
                             - '$value'
                             - 1
+    -
+        name: 'Round Average Rating'
+        pipeline:
+            -
+                $project:
+                    roundedAverageRating:
+                        $avg:
+                            -
+                                $round:
+                                    -
+                                        $avg:
+                                            - '$averageRating'
+                                    - 2
diff --git a/src/Builder/Expression/FactoryTrait.php b/src/Builder/Expression/FactoryTrait.php
diff --git a/src/Builder/Expression/RoundOperator.php b/src/Builder/Expression/RoundOperator.php
diff --git a/tests/Builder/Expression/Pipelines.php b/tests/Builder/Expression/Pipelines.php
diff --git a/tests/Builder/Expression/RoundOperatorTest.php b/tests/Builder/Expression/RoundOperatorTest.php
@@ -27,4 +27,22 @@ public function testExample(): void
 
         $this->assertSamePipeline(Pipelines::RoundExample, $pipeline);
     }
+
+    public function testRoundAverageRating(): void
+    {
+        $pipeline = new Pipeline(
+            Stage::project(
+                roundedAverageRating: Expression::avg(
+                    Expression::round(
+                        Expression::avg(
+                            Expression::doubleFieldPath('averageRating'),
+                        ),
+                        2,
+                    ),
+                ),
+            ),
+        );
+
+        $this->assertSamePipeline(Pipelines::RoundRoundAverageRating, $pipeline);
+    }
 }