Prohibit specifying codec and typeMap options to Watch

mongodb · Aug 23, 2023 · f532119 · f532119
1 parent 9cdb66a
commit f532119
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Operation/Watch.php b/src/Operation/Watch.php
@@ -210,6 +210,10 @@ public function __construct(Manager $manager, ?string $databaseName, ?string $co
  throw InvalidArgumentException::invalidType('"codec" option', $options['codec'], DocumentCodec::class);
  }
 
+ if (isset($options['codec']) && isset($options['typeMap'])) {
+ throw InvalidArgumentException::cannotCombineCodecAndTypeMap();
+ }
+
  if (array_key_exists('fullDocument', $options) && ! is_string($options['fullDocument'])) {
  throw InvalidArgumentException::invalidType('"fullDocument" option', $options['fullDocument'], 'string');
  }

diff --git a/tests/Operation/WatchTest.php b/tests/Operation/WatchTest.php
@@ -4,6 +4,7 @@
 
 use MongoDB\Exception\InvalidArgumentException;
 use MongoDB\Operation\Watch;
+use MongoDB\Tests\Fixtures\Codec\TestDocumentCodec;
 use stdClass;
 
 /**
@@ -57,6 +58,14 @@ public function provideInvalidConstructorOptions()
  ]);
  }
 
+ public function testConstructorRejectsCodecAndTypemap(): void
+ {
+ $this->expectExceptionObject(InvalidArgumentException::cannotCombineCodecAndTypeMap());
+
+ $options = ['codec' => new TestDocumentCodec(), 'typeMap' => ['root' => 'array']];
+ new Watch($this->manager, $this->getDatabaseName(), $this->getCollectionName(), [], $options);
+ }
+
  private function getInvalidTimestampValues()
  {
  return [123, 3.14, 'foo', true, [], new stdClass()];