PHPLIB-1404: Convert retryable reads spec tests to unified test format #1247
Conversation
| } | ||
| }, | ||
| "expectResult": { | ||
| "$$matchesHexBytes": "11" |
There was a problem hiding this comment.
Related to mongodb/specifications#1536
In findChunksByFileId(), we add additional criteria to the chunks query beyond the files_id expected in the original tests. The legacy test format permitted extra fields at all levels, so this was never checked.
I could have worked around this with $$matchAsRoot, but PHPLIB hasn't implemented that yet. Instead, I opted to relax the commandStartedEvent query to ignore filter altogether and instead assert the result of the successful operation (which was never done in the original tests).
| * @see https://github.com/mongodb/specifications/tree/master/source/retryable-reads | ||
| * @group serverless | ||
| */ | ||
| class RetryableReadsSpecTest extends FunctionalTestCase |
There was a problem hiding this comment.
Note: PHP has yet to implement any of the retryable reads prose tests. The CMAP prose test doesn't apply, and the mongos-related tests are waiting on PHPC-1911.
As such, there was nothing else in this file that needed to be kept.
|
|
||
| return $collection->mapReduce( | ||
| return iterator_to_array($collection->mapReduce( |
There was a problem hiding this comment.
Without this, the test runner attempted to match a MapReduceResult directly and timed out (likely due to some loop when dumping the comparison failure). This is consistent with eager iteration for other cursor-returning operations.
While looking into this, I wondered by we're still handling write result classes in ExpectedResult instead of immediately after an Operation. Opened PHPLIB-1406 to revisit that.
This works around an error for a distinct operation that references an entity created by a createEntities test runner operation.
| * be created by a createEntities test runner operation, the | ||
| * assertion below will fail; however, there is no need to | ||
| * address this until such a transaction test is created. */ | ||
| $collection = $context->getEntityMap()[$operation->object] ?? null; |
There was a problem hiding this comment.
Working around this would require running the createEntities operation ahead of time, which is a can of worms.
* v1.18: (50 commits) Enable auto-merge in merge-up workflow (#1295) PHPLIB-1447: Add SBOM lite (#1292) Fix syntax error in docs (#1285) PHPLIB-1163 Create tutorial for using MongoDB with Bref (#1273) (#1282) Create sarif report when running psalm (#1280) Update composer.json and CI matrices for 1.18.0 PHPLIB-1410: Invoke drivers-evergreen-tools scripts with bash (#1267) PHPLIB-1302: Use Composer\InstalledVersions (#1262) PHPLIB-1320: Support "comment" command option in Collection::createIndex() (#1263) PHPLIB-1413: Use env instead of matrix for driver-version (#1261) Fix Markdown heading PHPLIB-1399: Docs examples for agg expr projection (#1260) PHPLIB-1412: Skip range encryption tests on MongoDB 8.0+ (#1259) PHPLIB-1409: Skip $out and mapReduce tests on serverless (#1254) Exclude read-write-concern tests from serverless testing (#1253) PHPLIB-1409: Convert default write concern tests to unified test format (#1252) PHPLIB-1408: Convert ADL spec test to unified test format (#1250) Remove redundant annotations (#1251) PHPLIB-1404: Convert retryable reads spec tests to unified test format (#1247) DOCSP-36627: Additional double backslash fixes for master (#1246) ...
https://jira.mongodb.org/browse/PHPLIB-1404
POC for mongodb/specifications#1536
Patch build: https://spruce.mongodb.com/version/65ea17691e2d178a7a47bae9/tasks