PHPLIB-1489: Handle CursorId deprecations #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Jul 25, 2024
| public function getId(): CursorId | ||
| /** @return CursorId|Int64 */ | ||
| #[ReturnTypeWillChange] | ||
| public function getId(bool $asInt64 = false) |
There was a problem hiding this comment.
For BC layer, adding an argument should be virtual (func_get_arg).
There was a problem hiding this comment.
I thought the argument with a default value would be fine, can you explain why func_get_args works better?
There was a problem hiding this comment.
Although I'm not sure why or how anyone would extend this class.
GromNaN
previously approved these changes
Jul 25, 2024
alcaeus
force-pushed
the
phplib-1489-handle-cursorid-deprecation
branch
from
11890ef
to
162f789
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GromNaN
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-1489
This PR complements mongodb/mongo-php-driver#1616 by introducing the same
$asInt64argument to all classes that implementCursorInterface::getIdor wrap a cursor class. Not providing the argument or providingfalseas a value will trigger a deprecation warning to inform the user they need to update. In 2.0, we can deprecate the parameter and change the return type of the methods toInt64.