Remove Prose22_RangeExplicitEncryptionTest that requires ext-mongodb < 1.20
#1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested review from
alcaeus and
jmikola
and removed request for
alcaeus
GromNaN
force-pushed
the
remove-prose22
branch
3 times, most recently
from
e2e89b5
to
3ea51e7
Compare
GromNaN
commented
Sep 12, 2024
GromNaN
force-pushed
the
remove-prose22
branch
3 times, most recently
from
da7b9dc
to
d679db2
Compare
GromNaN
force-pushed
the
remove-prose22
branch
from
d679db2
to
5ef8b8b
Compare
alcaeus
approved these changes
Sep 13, 2024
Merged
jmikola
reviewed
Sep 13, 2024
|
|
||
| if (version_compare(phpversion('mongodb'), '1.20.0dev', '>=')) { | ||
| $this->markTestIncomplete('Range protocol V1 is not supported by ext-mongodb 1.20+'); | ||
| } |
There was a problem hiding this comment.
This should still be a valid prose test. I think the problem is that I didn't remove this skip when adding the server 8.0+ requirement below in 0b16223.
Based on the prose test definition, it should be run for server 8.0+ and libmongocrypt 1.11+. The accompanying JSON files have already been updated for QEv2 (since mongodb/specifications@9bfa512).
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Sep 13, 2024
…mongodb < 1.20 (mongodb#1394)" This reverts commit 0ed8dff.
GromNaN
added a commit
that referenced
this pull request
Sep 13, 2024
alcaeus
added a commit
that referenced
this pull request
Sep 19, 2024
* v1.x: (87 commits) Performance: Keep collections and indexes between GridFS tests (#1421) Add final annotations to non-internal Operation classes (#1410) Fix types accepted by $round (#1401) Replace arrayHasKey with assertArrayHasKey in tests (#1403) PHPLIB-1514 Make data providers static (#1404) PHPLIB-1515 Replace assertObjectHasAttribute with assertObjectHasProperty (#1405) Restore Prose22_RangeExplicitEncryptionTest (#1400) Remove Prose22_RangeExplicitEncryptionTest that requires ext-mongodb < 1.20 (#1394) Use `match` instead of `switch` when a simple value is returned (#1393) Remove PHPUnit functions polyfill (#1395) Update branch names for GHA workflows (#1390) PHPLIB-1419 Encode Agg builder objects in Collection methods (#1383) PHPLIB-1420 Integrate query builder for non-aggregation APIs (#1385) Fix optional parameter declared before required parameter (#1384) PHPLIB-1505 Add driver option "builderEncoder" (#1382) Exclude rector.php from the artifact Check generated files are up-to-date Replace composer package mongodb/builder Skip Pedentry method sort for generated files Remove composer constraints already imposed by the main package ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test class is skipped for
ext-mongodb >= 1.20devsince #1351And
ext-mongodb >= 1.20is required since #1350Conclusion: this tests are always skipped.