PHPLIB-1514 Make data providers static #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Sep 13, 2024
tests/TestCase.php
Outdated
| { | ||
| return [123, 3.14, 'foo', true, [], new stdClass(), $this->createMock(Codec::class)]; | ||
| return [123, 3.14, 'foo', true, [], new stdClass(), self::createStub(Codec::class)]; |
There was a problem hiding this comment.
Stubs can be created statically, mock cannot.
There was a problem hiding this comment.
We have to wait for PHPUnit 10 to use this function.
GromNaN
force-pushed
the
PHPLIB-1514
branch
from
49d35fb
to
21e944e
Compare
|
Do you want to address the six errors in this CI build first? |
GromNaN
force-pushed
the
PHPLIB-1514
branch
from
1224055
to
6de7408
Compare
GromNaN
force-pushed
the
PHPLIB-1514
branch
from
f2cca38
to
5bb47d7
Compare
jmikola
approved these changes
Sep 16, 2024
| @@ -53,7 +53,7 @@ protected function assertStreamContents(string $expectedContents, $stream): void | |||
| * | |||
| * @return resource | |||
| */ | |||
| protected function createStream(string $data = '') | |||
| protected static function createStream(string $data = '') | |||
There was a problem hiding this comment.
Technically not a data provider but there's also no reason this method can't be static 👍
There was a problem hiding this comment.
I made it static because It's used in a data provider.
| @@ -86,7 +86,7 @@ public function testWriteBytesCalculatesMD5($input, $expectedMD5): void | |||
| $this->assertSameDocument(['md5' => $expectedMD5], $fileDocument); | |||
| } | |||
|
|
|||
| public function provideInputDataAndExpectedMD5() | |||
| public static function provideInputDataAndExpectedMD5() | |||
There was a problem hiding this comment.
Expect a conflict with #1398 later.
| } | ||
| }; | ||
| // @fixme: createStub can be called statically in PHPUnit 10 | ||
| // $codec = self::createStub(Codec::class); |
There was a problem hiding this comment.
I assume once you upgrade the PHPUnit 10, the above anonymous class can be replaced with the single createStub() call?
Should this be tracked in a sub-task within PHPLIB-1369, or do you plan on addressing it in the main ticket?
There was a problem hiding this comment.
This was referenced Sep 16, 2024
Merged
Merged
alcaeus
added a commit
that referenced
this pull request
Sep 19, 2024
* v1.x: (87 commits) Performance: Keep collections and indexes between GridFS tests (#1421) Add final annotations to non-internal Operation classes (#1410) Fix types accepted by $round (#1401) Replace arrayHasKey with assertArrayHasKey in tests (#1403) PHPLIB-1514 Make data providers static (#1404) PHPLIB-1515 Replace assertObjectHasAttribute with assertObjectHasProperty (#1405) Restore Prose22_RangeExplicitEncryptionTest (#1400) Remove Prose22_RangeExplicitEncryptionTest that requires ext-mongodb < 1.20 (#1394) Use `match` instead of `switch` when a simple value is returned (#1393) Remove PHPUnit functions polyfill (#1395) Update branch names for GHA workflows (#1390) PHPLIB-1419 Encode Agg builder objects in Collection methods (#1383) PHPLIB-1420 Integrate query builder for non-aggregation APIs (#1385) Fix optional parameter declared before required parameter (#1384) PHPLIB-1505 Add driver option "builderEncoder" (#1382) Exclude rector.php from the artifact Check generated files are up-to-date Replace composer package mongodb/builder Skip Pedentry method sort for generated files Remove composer constraints already imposed by the main package ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1514
In order to upgrade to PHPUnit 10+, we need to make all data provider static.