PHPLIB-1525 Removes dependency to Symfony PHPUnit bridge #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Sep 17, 2024
alcaeus
reviewed
Sep 18, 2024
CONTRIBUTING.md
Outdated
|
|
||
| ```console | ||
| $ SYMFONY_PHPUNIT_VERSION=8.5 vendor/bin/simple-phpunit | ||
| $ vendor/bin/phpunit |
There was a problem hiding this comment.
We document running the test suite with composer run test a few lines above (can't add a comment to the corresponding context line). We could document the direct way of calling the phpunit binary up there and remove this entire paragraph.
GromNaN
force-pushed
the
PHPLIB-1525
branch
2 times, most recently
from
6e8cdd4
to
bc7cad4
Compare
GromNaN
force-pushed
the
PHPLIB-1525
branch
from
bc7cad4
to
3ce4d6a
Compare
GromNaN
force-pushed
the
PHPLIB-1525
branch
from
aa4f51a
to
a8ace60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1525
We don't use any of this features.
The bridge also helps in maintaining custom constraints compatible with multiple versions of PHPUnit, due to type changes between versions 7, 8 and 9. This should longer be required as the Constraint class is fully typed.
drivers-atlas-testing will require an update: