Use host:port for server logging and add extra fields to EventCollector logs #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server's connection ID is unique within the context of a single server and is only reported by MongoDB 4.2+. It should not be used to uniquely identify a server. This reverts recent changes from 50d1db7.
This renames connectionId to server, to avoid ambiguity with serverConnectionId. Additional fields have also been added to the output. Since PHPC 1.19, database name is available on all APM events.
GromNaN
reviewed
Sep 19, 2024
Comment on lines
-130
to
-132
| if ($event instanceof CommandStartedEvent) { | ||
| $log['databaseName'] = $event->getDatabaseName(); | ||
| } |
There was a problem hiding this comment.
It's now added unconditionally a few lines up.
This original logic predated PHPC 1.19 adding the property to all APM events in PHPC-2255.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects some changes introduced in #1423