Deprecate functionality to be removed #1441
Open
+39
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Sep 23, 2024
| @@ -927,6 +931,8 @@ public function listSearchIndexes(array $options = []): Iterator | |||
| */ | |||
| public function mapReduce(JavascriptInterface $map, JavascriptInterface $reduce, $out, array $options = []) | |||
| { | |||
| @trigger_error(sprintf('The %s method is deprecated and will be removed in a future release.', __METHOD__), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Will you remove it in version 2.0? In that case, you can mention the version here.
Suggested change
| @trigger_error(sprintf('The %s method is deprecated and will be removed in a future release.', __METHOD__), E_USER_DEPRECATED); | |
| @trigger_error(sprintf('The %s method is deprecated and will be removed in version 2.0.', __METHOD__), E_USER_DEPRECATED); |
jmikola
reviewed
Sep 23, 2024
|
|
||
| if (isset($options['oplogReplay'])) { | ||
| @trigger_error('The "oplogReplay" option is deprecated and will be removed in a future release', E_USER_DEPRECATED); | ||
| } |
There was a problem hiding this comment.
Excluding modifiers, PHPC raises its own E_DEPRECATED notice these options in the Query constructor. Does that mean users would see two deprecation notices?
As for modifiers, that seems like something we should add in PHPC 1.x before we remove the option entirely in 2.0 (PHPC-2440). I created PHPC-2452 and opened mongodb/mongo-php-driver#1677 to address that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deprecations for the
modifiersandoplogReplayoptions infindoperations (PHPLIB-1532) as well as theCollection::mapReducemethod (PHPLIB-1533).