Skip to content

Commit

Permalink
Remove is_monitor
Browse files Browse the repository at this point in the history
  • Loading branch information
NoahStapp committed Jun 25, 2024
1 parent 49c5f01 commit 110970f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 22 deletions.
12 changes: 2 additions & 10 deletions pymongo/asynchronous/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,6 @@ class PoolOptions:
"__server_api",
"__load_balanced",
"__credentials",
"__is_monitor",
)

def __init__(
Expand All @@ -540,7 +539,6 @@ def __init__(
server_api: Optional[ServerApi] = None,
load_balanced: Optional[bool] = None,
credentials: Optional[MongoCredential] = None,
is_monitor: Optional[bool] = False,
):
self.__max_pool_size = max_pool_size
self.__min_pool_size = min_pool_size
Expand All @@ -560,7 +558,6 @@ def __init__(
self.__load_balanced = load_balanced
self.__credentials = credentials
self.__metadata = copy.deepcopy(_METADATA)
self.__is_monitor = is_monitor
if appname:
self.__metadata["application"] = {"name": appname}

Expand Down Expand Up @@ -720,11 +717,6 @@ def load_balanced(self) -> Optional[bool]:
"""True if this Pool is configured in load balanced mode."""
return self.__load_balanced

@property
def is_monitor(self) -> Optional[bool]:
"""True if this Pool is owned by a Monitor."""
return self.__is_monitor


class _CancellationContext:
def __init__(self) -> None:
Expand Down Expand Up @@ -770,7 +762,7 @@ def __init__(
self.op_msg_enabled = False
self.listeners = pool.opts._event_listeners
self.enabled_for_cmap = pool.enabled_for_cmap
self.enabled_for_logging = pool.enabled_for_cmap
self.enabled_for_logging = pool.enabled_for_logging
self.compression_settings = pool.opts._compression_settings
self.compression_context: Union[SnappyContext, ZlibContext, ZstdContext, None] = None
self.socket_checker: SocketChecker = SocketChecker()
Expand Down Expand Up @@ -1489,7 +1481,7 @@ def __init__(
and self.opts._event_listeners is not None
and self.opts._event_listeners.enabled_for_cmap
)
self.enabled_for_logging = self.handshake and not self.opts.is_monitor
self.enabled_for_logging = self.handshake

# The first portion of the wait queue.
# Enforces: maxPoolSize
Expand Down
1 change: 0 additions & 1 deletion pymongo/asynchronous/topology.py
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,6 @@ def _create_pool_for_monitor(self, address: _Address) -> Pool:
driver=options.driver,
pause_enabled=False,
server_api=options.server_api,
is_monitor=True,
)

return self._settings.pool_class(
Expand Down
12 changes: 2 additions & 10 deletions pymongo/synchronous/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,6 @@ class PoolOptions:
"__server_api",
"__load_balanced",
"__credentials",
"__is_monitor",
)

def __init__(
Expand All @@ -540,7 +539,6 @@ def __init__(
server_api: Optional[ServerApi] = None,
load_balanced: Optional[bool] = None,
credentials: Optional[MongoCredential] = None,
is_monitor: Optional[bool] = False,
):
self.__max_pool_size = max_pool_size
self.__min_pool_size = min_pool_size
Expand All @@ -560,7 +558,6 @@ def __init__(
self.__load_balanced = load_balanced
self.__credentials = credentials
self.__metadata = copy.deepcopy(_METADATA)
self.__is_monitor = is_monitor
if appname:
self.__metadata["application"] = {"name": appname}

Expand Down Expand Up @@ -720,11 +717,6 @@ def load_balanced(self) -> Optional[bool]:
"""True if this Pool is configured in load balanced mode."""
return self.__load_balanced

@property
def is_monitor(self) -> Optional[bool]:
"""True if this Pool is owned by a Monitor."""
return self.__is_monitor


class _CancellationContext:
def __init__(self) -> None:
Expand Down Expand Up @@ -770,7 +762,7 @@ def __init__(
self.op_msg_enabled = False
self.listeners = pool.opts._event_listeners
self.enabled_for_cmap = pool.enabled_for_cmap
self.enabled_for_logging = pool.enabled_for_cmap
self.enabled_for_logging = pool.enabled_for_logging
self.compression_settings = pool.opts._compression_settings
self.compression_context: Union[SnappyContext, ZlibContext, ZstdContext, None] = None
self.socket_checker: SocketChecker = SocketChecker()
Expand Down Expand Up @@ -1485,7 +1477,7 @@ def __init__(
and self.opts._event_listeners is not None
and self.opts._event_listeners.enabled_for_cmap
)
self.enabled_for_logging = self.handshake and not self.opts.is_monitor
self.enabled_for_logging = self.handshake

# The first portion of the wait queue.
# Enforces: maxPoolSize
Expand Down
1 change: 0 additions & 1 deletion pymongo/synchronous/topology.py
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,6 @@ def _create_pool_for_monitor(self, address: _Address) -> Pool:
driver=options.driver,
pause_enabled=False,
server_api=options.server_api,
is_monitor=True,
)

return self._settings.pool_class(
Expand Down

0 comments on commit 110970f

Please sign in to comment.