PYTHON-4480 Deprecate create=True for Collection #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
reviewed
Jun 6, 2024
| @@ -197,12 +197,6 @@ def test_create(self): | |||
| lambda: "create_test_no_wc" in db.list_collection_names(), | |||
| "create create_test_no_wc collection", | |||
| ) | |||
| db.create_test_no_wc.drop() | |||
There was a problem hiding this comment.
We should keep this and catch the warning.
There was a problem hiding this comment.
Correct, when we deprecate something we keep the tests and also add an extra assertion to ensure the warning is actually raised.
ShaneHarvey
reviewed
Jun 6, 2024
pymongo/asynchronous/collection.py
Outdated
| @@ -248,6 +249,11 @@ def __init__( | |||
|
|
|||
| if create or kwargs: | |||
| if _IS_SYNC: | |||
| warnings.warn( | |||
| "The `create` and `kwargs` arguments are deprecated and will be removed in PyMongo 5.0", | |||
There was a problem hiding this comment.
I would add "arguments to Collection are..."
| @@ -197,12 +197,6 @@ def test_create(self): | |||
| lambda: "create_test_no_wc" in db.list_collection_names(), | |||
| "create create_test_no_wc collection", | |||
| ) | |||
| db.create_test_no_wc.drop() | |||
There was a problem hiding this comment.
Correct, when we deprecate something we keep the tests and also add an extra assertion to ensure the warning is actually raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.