Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-4503 - Re-enable accidentally disabled tests #1683

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

NoahStapp
Copy link
Contributor

No description provided.

Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines -303 to -308
async def _socket_for_reads_async(self, read_preference, session):
context = await super()._socket_for_reads_async(read_preference, session)
async with context as (sock_info, read_preference):
self.record_a_read(sock_info.address)
return await super()._socket_for_reads_async(read_preference, session)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I"m guessing this is now unneeded/unused?

@NoahStapp NoahStapp merged commit 8b6bb83 into mongodb:master Jun 14, 2024
32 of 34 checks passed
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants