-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-4504 Use a venv for mod_wsgi test #1687
Conversation
.evergreen/run-mod-wsgi-tests.sh
Outdated
@@ -45,3 +47,5 @@ ${PYTHON_BINARY} ${PROJECT_DIRECTORY}/test/mod_wsgi_test/test_client.py -n 25000 | |||
${PYTHON_BINARY} ${PROJECT_DIRECTORY}/test/mod_wsgi_test/test_client.py -n 25000 serial \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace these PYTHON_BINARY usages with "python".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
${PYTHON_BINARY} -m pip install -e . | ||
${PYTHON_BINARY} -m venv .venv | ||
source .venv/bin/activate | ||
python -m pip install -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we need to create the venv with --system-site-packages so that the toolchain installed version of mod_wsgi can be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Python 3.8 is failing:
Does this mean we need to revert the hatch change and bring back setup.py? |
Trying with an updated |
I opened https://jira.mongodb.org/browse/PYTHON-4507 to document the new pip requirements. |
Do you know why the import time check is failing?
|
I'm not sure what changed, I thought I had accounted for git state originally. |
Ready to merge, since we have PYTHON-4508, and it was pre-existing? |
I thought you might want to fix it in this PR since the import check started failing in the first mod_wsgi change: #1684 Fewer backports that way. |
(cherry picked from commit bba5f81)
No description provided.