PYTHON-4763 Migrate test_change_stream.py to async #1853
Conversation
test/test_change_stream.py
Outdated
| @@ -310,7 +312,7 @@ def _test_next_blocks(self, change_stream): | |||
| @no_type_check | |||
| def test_next_blocks(self): | |||
| """Test that next blocks until a change is readable""" | |||
| # Use a short await time to speed up the test. | |||
| # Use a short time to speed up the test. | |||
There was a problem hiding this comment.
| # Use a short time to speed up the test. | |
| # Use a short wait time to speed up the test. |
test/test_change_stream.py
Outdated
| @@ -325,7 +327,7 @@ def test_aggregate_cursor_blocks(self): | |||
| @no_type_check | |||
| def test_concurrent_close(self): | |||
| """Ensure a ChangeStream can be closed from another thread.""" | |||
| # Use a short await time to speed up the test. | |||
| # Use a short time to speed up the test. | |||
There was a problem hiding this comment.
| # Use a short time to speed up the test. | |
| # Use a short wait time to speed up the test. |
omg one sec, i always forget that -a doesn't add the file... ;-; |
|
like fifty attempts later, its ready HAHA |
| @@ -158,10 +162,14 @@ def test_try_next(self): | |||
| with self.change_stream(max_await_time_ms=250) as stream: | |||
| self.assertIsNone(stream.try_next()) # No changes initially. | |||
| coll.insert_one({}) # Generate a change. | |||
|
|
|||
There was a problem hiding this comment.
Unneeded added space here.
There was a problem hiding this comment.
Yeah...I'll try again for sure, but i tried to delete it and when i ran pre-commit it was added again??? not sure why though
There was a problem hiding this comment.
Because the async file overwrites the sync one
There was a problem hiding this comment.
ohh, I think it is because ruff is just doing that because the file has changed
There was a problem hiding this comment.
yeah so I found the space in the async file, deleted it, and then it got added back during pre-commit
There was a problem hiding this comment.
Ah in that case never mind, if the formatter adds an extra space that's fine.
There was a problem hiding this comment.
perfect, because I just gave up on trying to convince it otherwise
test/test_change_stream.py
Outdated
| wait_until(lambda: stream.try_next() is not None, "get change from try_next") | ||
|
|
||
| def _wait_until(): | ||
| return stream.try_next() |
There was a problem hiding this comment.
| return stream.try_next() | |
| return stream.try_next() is not None |
test/test_change_stream.py
Outdated
| wait_until(lambda: stream.try_next() is not None, "get change from try_next") | ||
|
|
||
| def _wait_until(): | ||
| return stream.try_next() |
There was a problem hiding this comment.
| return stream.try_next() | |
| return stream.try_next() is not None |
No description provided.