PYTHON-4879 Use shrub.py for compressor tests #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
approved these changes
Oct 17, 2024
NoahStapp
previously requested changes
Oct 17, 2024
| ################## | ||
| # Generate Config | ||
| ################## | ||
|
|
||
| generate_yaml(variants=create_load_balancer_variants()) | ||
| variants = create_compression_variants() | ||
| # print(len(variants)) |
There was a problem hiding this comment.
Suggested change
| # print(len(variants)) |
There was a problem hiding this comment.
I've been using that for debugging, toggling between that line and the next
There was a problem hiding this comment.
Should we keep it in this final merge into master? Feels like it's unneeded for a master commit.
There was a problem hiding this comment.
I'll just have to keep adding it back in every time while I'm building out these variants, doesn't seem worth doing
There was a problem hiding this comment.
Can you let me know when the last shrub conversion PR is then? That way I know when any debugging code should be gone.
There was a problem hiding this comment.
When I close the main ticket lol, a long way off
NoahStapp
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: 288 tasks across 36 build variants
After: 78 tasks across 9 build variants