remove noResponse deprecation - do in node-6377

lint fix
mongodb · Sep 16, 2024 · 6104c57 · 6104c57
1 parent 56772b7
commit 6104c57
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/src/cmap/commands.ts b/src/cmap/commands.ts
@@ -475,7 +475,7 @@ export class OpMsgRequest {
 
     // flags
     this.checksumPresent = false;
-    this.moreToCome = options.moreToCome || command.writeConcern?.w === 0 || false;
+    this.moreToCome = options.moreToCome ?? command.writeConcern?.w === 0;
     this.exhaustAllowed =
       typeof options.exhaustAllowed === 'boolean' ? options.exhaustAllowed : false;
   }

diff --git a/src/operations/command.ts b/src/operations/command.ts
@@ -55,12 +55,6 @@ export interface CommandOperationOptions
   // Admin command overrides.
   dbName?: string;
   authdb?: string;
-  /**
-   * @deprecated
-   * Will be removed in the next major version. Set writeConcern.w to 0 instead.
-   *
-   * **WARNING:** When this flag is true, it may result in indeterminate driver behavior.
-   */
   noResponse?: boolean;
 }
 

diff --git a/test/integration/node-specific/mongo_client.test.ts b/test/integration/node-specific/mongo_client.test.ts
@@ -698,7 +698,7 @@ describe('class MongoClient', function () {
       expect(startedEvents).to.have.lengthOf(1);
       expect(startedEvents[0]).to.have.property('commandName', 'endSessions');
       expect(endEvents).to.have.lengthOf(1);
-      expect(endEvents[0]).to.property('reply', undefined);
+      expect(endEvents[0]).to.have.property('reply', undefined); // noReponse: true
     });
 
     context('when server selection would return no servers', () => {