test(NODE-5342): modernize explain tests #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
added
the
Primary Review
W-A-James
requested changes
Jun 12, 2023
W-A-James
requested changes
Jun 14, 2023
W-A-James
previously approved these changes
Jun 14, 2023
W-A-James
added
Team Review
dariakp
requested changes
Jun 14, 2023
There was a problem hiding this comment.
I did not review the entire set of tests, but I think it would be worthwhile to double check all test cases and make sure that 1) the "it" blocks accurately capture the behavior of interest and 2) the assertions fully test the described behavior. I called out one example of what I mean, let me know if you have any questions.
dariakp
requested changes
Jun 16, 2023
dariakp
requested changes
Jun 27, 2023
W-A-James
requested changes
Jun 28, 2023
baileympearson
previously requested changes
Jun 28, 2023
W-A-James
previously approved these changes
Jun 28, 2023
dariakp
previously approved these changes
Jun 28, 2023
W-A-James
previously approved these changes
Jun 28, 2023
W-A-James
dismissed
baileympearson’s stale review
Concerns addressed in subsequent commits
W-A-James
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
explain tests modernized
removed metadata
converted to typescript
Is there new documentation needed for these changes?
no
What is the motivation for this change?
new things are nice and look clean
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript