Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-5352): refactor AbstractOperation to use async #3729

Merged
merged 23 commits into from
Jun 29, 2023
Merged

refactor(NODE-5352): refactor AbstractOperation to use async #3729

merged 23 commits into from
Jun 29, 2023

Commits on Jun 29, 2023

  1. test(NODE-5342): modernize explain tests

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    14363bd View commit details
    Browse the repository at this point in the history

  2. grouped aggregates under context block

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    711c17c View commit details
    Browse the repository at this point in the history

  3. fixed formatting

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    f2c449b View commit details
    Browse the repository at this point in the history

  4. added server.commanAsync wrapper to server class

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    cbd60e6 View commit details
    Browse the repository at this point in the history

  5. created AbstractCallbackOperation class 

    changed all operations to extend AbstractCallbackOperation
changed all operations from execute to executeCallback
    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    95fcf8e View commit details
    Browse the repository at this point in the history

  6. tested connection.commandAsync

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b3ba8e6 View commit details
    Browse the repository at this point in the history

  7. tested server.commandAsync calls server.command

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b9797de View commit details
    Browse the repository at this point in the history

  8. Minor changes

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    80ff7b4 View commit details
    Browse the repository at this point in the history

  9. changed default generic 

    changed async tests to await
    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    430fea5 View commit details
    Browse the repository at this point in the history

  10. minor edit

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    c26267e View commit details
    Browse the repository at this point in the history

  11. copied mock server test code

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    0664585 View commit details
    Browse the repository at this point in the history

  12. created mock server to fix test errors

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    209bdbb View commit details
    Browse the repository at this point in the history

  13. removed .only

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    38ebdc3 View commit details
    Browse the repository at this point in the history

  14. added arguments to commandAsync

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    77a5c3c View commit details
    Browse the repository at this point in the history

  15. moved server code to connection test

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    6d4cad8 View commit details
    Browse the repository at this point in the history

  16. cleaned server test

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    9580b07 View commit details
    Browse the repository at this point in the history

  17. added sinon.stub to give mock command reply

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b1e41dc View commit details
    Browse the repository at this point in the history

  18. changed execute to executeCallback in tests

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    0f2cdb3 View commit details
    Browse the repository at this point in the history

  19. removed unused variables

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b558f05 View commit details
    Browse the repository at this point in the history

  20. removed promisify

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    82c1429 View commit details
    Browse the repository at this point in the history

  21. created AbstractCallbackOperation class 

    changed all operations to extend AbstractCallbackOperation
changed all operations from execute to executeCallback
    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    49aeed0 View commit details
    Browse the repository at this point in the history

  22. explain

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    a055b40 View commit details
    Browse the repository at this point in the history

  23. removed .bind

    @malikj2000
    malikj2000 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    14ab51e View commit details
    Browse the repository at this point in the history