Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(NODE-5361): use task groups for lambda #3740

Merged
merged 11 commits into from
Jun 28, 2023
Merged

ci(NODE-5361): use task groups for lambda #3740

merged 11 commits into from
Jun 28, 2023

Conversation

durran
Copy link
Member

@durran durran commented Jun 22, 2023

Description

Switches the deployed AWS Lambda tests to use task groups for more consistent setup and teardown.

What is changing?

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5361/DRIVERS-2657 and not losing money on orphaned Atlas clusters.

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're only running this task every 14 days on main, should we be running it on PRs?

Otherwise, the changes look good.

@durran
Copy link
Member Author

durran commented Jun 28, 2023

If we're only running this task every 14 days on main, should we be running it on PRs?

Otherwise, the changes look good.

I've removed now.

@baileympearson baileympearson changed the title test(NODE-5361): use task groups for lambda ci(NODE-5361): use task groups for lambda Jun 28, 2023
@baileympearson baileympearson merged commit 1d31888 into main Jun 28, 2023
1 check passed
@baileympearson baileympearson deleted the NODE-5361 branch June 28, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants