Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5853): support delegated KMIP data key option #4129

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 4, 2024

Description

What is changing?

A new option for creating a KMIP data key, delegated is now supported.

Is there new documentation needed for these changes?

No.

Release Highlight

KMIP data keys now support a delegated option

When creating a KMIP data key, delegated can now be specified. If true, the KMIP provider will perform encryption / decryption of the data key locally, ensuring that the encryption key never leaves the KMIP server.

clientEncryption.createDataKey('kmip', { masterKey: { delegated: true } } );

This feature requires mongodb-client-encryption>=6.0.1.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the delegated-option branch 3 times, most recently from 1aed887 to 071be12 Compare June 5, 2024 17:42
@nbbeeken nbbeeken self-assigned this Jun 5, 2024
@baileympearson baileympearson marked this pull request as ready for review June 6, 2024 14:10
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 6, 2024
@nbbeeken nbbeeken self-requested a review June 6, 2024 20:15
@nbbeeken nbbeeken merged commit aa429f8 into mongodb:main Jun 6, 2024
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants