Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6276): preserve top level error code MongoWriteConcernError #4183

Merged
merged 5 commits into from
Jul 26, 2024
Merged

fix(NODE-6276): preserve top level error code MongoWriteConcernError #4183

merged 5 commits into from
Jul 26, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Jul 25, 2024 •
edited
Loading

Description

Preserve top level error code MongoWriteConcernError

What is changing?

Ensure that MongoWriteConcernError is correctly formed such that the original top-level code is preserved

  • If no top-level code exists, MongoWriteConcernError.code should be set to the nested code
  • If a top-level code is passed into the constructor, it shouldn't be changed or overwritten by the nested writeConcernError.code
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Bug fix

Release Highlight

MongoWriteConcernError.code is overwritten by nested code within MongoWriteConcernError.result.writeConcernError.code

MongoWriteConcernError is now correctly formed such that the original top-level code is preserved

  • If no top-level code exists, MongoWriteConcernError.code should be set to MongoWriteConcernError.result.writeConcernError.code
  • If a top-level code is passed into the constructor, it shouldn't be changed or overwritten by the nested writeConcernError.code

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB force-pushed the NODE-6276/MongoWriteConcernError-bug-fix branch from 96d4362 to 355f05d Compare July 25, 2024 22:07
@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review July 26, 2024 15:59
@baileympearson baileympearson self-assigned this Jul 26, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 26, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB force-pushed the NODE-6276/MongoWriteConcernError-bug-fix branch from d03a2b5 to 10a6629 Compare July 26, 2024 17:04
@baileympearson baileympearson merged commit e902584 into main Jul 26, 2024
25 of 29 checks passed
@baileympearson baileympearson deleted the NODE-6276/MongoWriteConcernError-bug-fix branch July 26, 2024 21:21
@github-actions github-actions bot mentioned this pull request Jul 26, 2024
Merged
This was referenced Oct 3, 2024
Merged
Merged
Merged
Merged
Closed
@skanda890 skanda890 mentioned this pull request Oct 4, 2024
Merged
@aravindbuilt aravindbuilt mentioned this pull request Oct 4, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request Oct 4, 2024
Open
@zntb zntb mentioned this pull request Oct 4, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 4, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 4, 2024
Open
@lryanle lryanle mentioned this pull request Oct 4, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Oct 4, 2024
Closed
@issam-seghir issam-seghir mentioned this pull request Oct 4, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Oct 4, 2024
Merged
@visrut-at-incubyte visrut-at-incubyte mentioned this pull request Oct 4, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
This was referenced Oct 5, 2024
Merged
Merged
Merged
@arenault-pass arenault-pass mentioned this pull request Oct 5, 2024
Closed
@MoaidHashem3 MoaidHashem3 mentioned this pull request Oct 5, 2024
Open
@mkusztal mkusztal mentioned this pull request Oct 5, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 5, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Oct 6, 2024
Closed
@Abhishekh669 Abhishekh669 mentioned this pull request Oct 25, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Oct 25, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Oct 26, 2024
Closed
@Xcaciv Xcaciv mentioned this pull request Oct 26, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 28, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 28, 2024
Open
@xeni09 xeni09 mentioned this pull request Oct 28, 2024
Merged
@abaum65 abaum65 mentioned this pull request Oct 29, 2024
Open
@mentorscx mentorscx mentioned this pull request Nov 7, 2024
Open
@prosenjit07 prosenjit07 mentioned this pull request Nov 8, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aditi-khare-mongoDB @baileympearson